Commits
Tarun Sukhani authored 2d1c14f9614
refactor: remove deprecated 14-arg Http.Request.createRequest (PF-76) Migrate all in-tree callers of the legacy 14-positional-parameter Http.Request.createRequest overload to the modern createRequest(RequestData) form, then delete the deprecated overload itself. Sites migrated (7): - framework/src/play/test/FunctionalTest.java (newRequest) - framework/src/play/test/TestEngine.java - framework/test-src/play/PlayBuilder.java (initMvcObject) - framework/test-src/play/mvc/HttpRequestTest.java - framework/test-src/play/mvc/RouterTest.java (3 sites) The RequestData record (Http.java:327) groups the 14 inputs into a single parameter object, eliminating the positional-drift hazard the deprecated overload was prone to (14 args, several adjacent same-typed booleans and strings, easy to mis-order at the call site). Argument order in the record matches the deprecated overload exactly, so the migration is mechanical. Breaking change: this is a SemVer-major change for downstream Play adapter modules that built Request instances via the legacy 14-arg form (e.g. the PlayGrizzlyAdapter cited in the now-deleted Javadoc). Such adapters must switch to createRequest(new Request.RequestData(...)) when consuming this release. Verification: ant clean unittest passes (BUILD SUCCESSFUL, 0 failures). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>