Commits
Tarun Sukhani authored 5ea52c42e8a
feat: enable-https sets %test.https.port=-1, disable-https comments it (PF-72, release 1.12.23) Keeps the test framework-id HTTPS line in lockstep with the dev https.port toggle so test runs (play test, FunctionalTest forks) don't try to bind the same HTTPS port as a live dev server. Behavior matrix: State dev https.port %test.https.port Fresh app absent absent After play enable-https 9443 (active) -1 (active) After play disable-https # 9443 (cmtd) # -1 (cmtd) Re-run enable-https 9443 (active) -1 (active) -1 is the framework's "do not bind" sentinel per Server.java. Setting it on the test framework-id keeps tests on the plain-HTTP path only. Tests that explicitly want HTTPS on a different port (e.g. the integration testapp at %test.https.port=19443) keep their custom value across enable-https runs — the same active-line guard that already protects a user's custom https.port=8443 or http.port=8080. End-to-end verified on /tmp/pf72test: - AC1: enable-https on fresh app produces both https.port=9443 and %test.https.port=-1 as active lines - AC2: disable-https comments both - AC3 (implicit): -1 sentinel is honored by Server.java's port-handling per the framework's existing convention - AC4: a manually-set %test.https.port=19443 survives enable-https unchanged Http2FunctionalTest still green — the integration testapp's pinned %test.https.port=19443 is untouched by this change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>