Commits
Tarun Sukhani authored 863a33a7607
refactor: consolidate ant test targets and prune samples-and-tests dead code (PF-80)
ant test is now the single ordered verification entrypoint for the framework:
clean -> jar -> unittest -> integration-test -> cli-test -> success. The
target body itself was already mostly correct after cf494a7ba (the
samples-and-tests removal), but several adjacent build.xml targets and CLAUDE.md
references were left stale and have been cleaned up here.
Removed dead targets (all unreachable since cf494a7ba)
- test-application: forked Play against ${application.path} for an in-tree
sample app. No such app exists anymore.
- play-test: invoked `play auto-test ${testAppPath}` against a sample app.
Same reason.
- do-deps + check-dependencies-file: only consumed by play-test.
- test-in-nb: NetBeans-specific (nbbrowse) and pointed at
tests-results/html/index.html which the current test pipeline never
generates.
Test infrastructure consolidation
- compile-tests now also copies non-Java resource fixtures (.plugins, .yml,
.properties, images) into test-classes. Previously this copy was only in
compile-unittest, which silently broke any resource-loading test invoked
via test-single (surfaced during PF-5 work — PluginCollectionTest's
custom-play.plugins fixture lookups returned null under test-single).
- compile-unittest is removed; unittest now depends on compile-tests directly.
No need for unittest's redundant agent-jar dep — compile-tests already
carries it (PF-79).
- clean-unittest -> clean-tests (renamed for clarity now that there's one
test-classes target).
Doc cleanup
- CLAUDE.md "Build & Test Commands" block now documents the actual targets
(unittest / integration-test / cli-test / test) instead of claiming the
full suite runs sample-app functional tests it no longer has access to.
- "Testing Patterns" section reflects the three real test categories
(framework JUnit, integration JUnit under test-src/integration/, CLI
Python tests under test-src/cli/).
- artifact target's dist-zip fileset no longer has stale samples-and-tests/**
exclude patterns.
Verified
- ant clean && ant test: BUILD SUCCESSFUL (full pipeline, ~30s)
- ant clean && ant test-single -Dtestclass=play.plugins.PluginCollectionTest:
9/9 pass (the resource-fixture footgun is fixed)
- ant unittest, ant integration-test, ant cli-test: all standalone-runnable
Net diff: 2 files, +36/-107.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>